Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1422673002: Extract Notifications kClickWasNotAnAction constant

Created:
5 years, 2 months ago by johnme
Modified:
5 years ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, mlamouri+watch-notifications_chromium.org, sdefresne+watchlist_chromium.org, jam, darin-cc_chromium.org, peter+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@actions_spec_sync
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract Notifications kClickWasNotAnAction constant BUG=513671

Patch Set 1 #

Total comments: 5

Messages

Total messages: 6 (1 generated)
johnme
5 years, 2 months ago (2015-10-22 11:19:18 UTC) #2
Peter Beverloo
https://codereview.chromium.org/1422673002/diff/1/components/test_runner/DEPS File components/test_runner/DEPS (right): https://codereview.chromium.org/1422673002/diff/1/components/test_runner/DEPS#newcode3 components/test_runner/DEPS:3: "+content/public/common", //content/shell and //content/test depend on this component, but ...
5 years, 2 months ago (2015-10-22 11:33:39 UTC) #3
Peter Beverloo
https://codereview.chromium.org/1422673002/diff/1/components/test_runner/DEPS File components/test_runner/DEPS (right): https://codereview.chromium.org/1422673002/diff/1/components/test_runner/DEPS#newcode3 components/test_runner/DEPS:3: "+content/public/common", On 2015/10/22 11:33:39, Peter Beverloo wrote: > //content/shell ...
5 years, 2 months ago (2015-10-22 15:03:42 UTC) #4
Peter Beverloo
Ping?
5 years, 1 month ago (2015-11-19 17:20:03 UTC) #5
Peter Beverloo
5 years ago (2015-12-15 15:50:50 UTC) #6
Ping?...

Powered by Google App Engine
This is Rietveld 408576698