components/test_runner/test_runner.cc - Issue 1422673002: Extract Notifications kClickWasNotAnAction constant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.cc

Issue 1422673002: Extract Notifications kClickWasNotAnAction constant Base URL: https://chromium.googlesource.com/chromium/src.git@actions_spec_sync

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/test_runner/DEPS ('K') | « components/test_runner/DEPS ('k') | content/browser/notifications/notification_database_data_unittest.cc » ('j') | content/public/common/platform_notification_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/test_runner.cc

diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc

index 023c8d6455440eb5443a0a97053e47c95b945795..785e818ac32e04783364afceee00fca9ea200691 100644

--- a/components/test_runner/test_runner.cc

+++ b/components/test_runner/test_runner.cc

@@ -15,6 +15,7 @@

#include "components/test_runner/web_content_settings.h"

#include "components/test_runner/web_test_delegate.h"

#include "components/test_runner/web_test_proxy.h"

+#include "content/public/common/platform_notification_data.h"

#include "gin/arguments.h"

#include "gin/array_buffer.h"

#include "gin/handle.h"

@@ -1389,7 +1390,7 @@ void TestRunnerBindings::SimulateWebNotificationClick(gin::Arguments* args) {

if (!runner_)

return;

std::string title;

- int action_index = -1;

+ int action_index = content::kNotificationClickWasNotAnAction;

if (args->GetNext(&title) &&

(args->PeekNext().IsEmpty() || args->GetNext(&action_index)))

runner_->SimulateWebNotificationClick(title, action_index);