components/test_runner/DEPS - Issue 1422673002: Extract Notifications kClickWasNotAnAction constant

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/test_runner/DEPS

Issue 1422673002: Extract Notifications kClickWasNotAnAction constant Base URL: https://chromium.googlesource.com/chromium/src.git@actions_spec_sync

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/notifications/persistent_notification_delegate.cc ('k') | components/test_runner/test_runner.cc » ('j') | content/public/common/platform_notification_data.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+cc",	2 "+cc",

	3 "+content/public/common",
	Peter Beverloo 2015/10/22 11:33:39 //content/shell and //content/test depend on this //content/shell and //content/test depend on this component, but not //content/public, so this should be fine. Please ask jochen@ to verify. Peter Beverloo 2015/10/22 15:03:42 Actually, no, test_runner should not depend on con Show quoted text On 2015/10/22 11:33:39, Peter Beverloo wrote: > //content/shell and //content/test depend on this component, but not > //content/public, so this should be fine. Please ask jochen@ to verify. Actually, no, test_runner should not depend on content at all. Just duplicate the constant in there?
3 "+gin",	4 "+gin",

4 "+net/base",	5 "+net/base",

5 "+skia",	6 "+skia",

6 "+third_party/skia",	7 "+third_party/skia",

7 "+third_party/WebKit/public/platform",	8 "+third_party/WebKit/public/platform",

8 "+third_party/WebKit/public/web",	9 "+third_party/WebKit/public/web",

9 "+ui/events",	10 "+ui/events",

10 "+ui/gfx",	11 "+ui/gfx",

11 "+v8/include",	12 "+v8/include",

12 ]	13 ]

OLD	NEW