Issue 1422573009: Don't bother clearing the wrapper of an abstract event listener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1422573009: Don't bother clearing the wrapper of an abstract event listener (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
5 years, 1 month ago

Reviewers:
haraken

CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't bother clearing the wrapper of an abstract event listener We're dropping our reference to it anyways, so it'll get GC'd eventually. Also, we don't have a script state at this point, so it's really hard to do this the right way. BUG=none R=haraken@chromium.org

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages