third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp - Issue 1422573009: Don't bother clearing the wrapper of an abstract event listener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

Issue 1422573009: Don't bother clearing the wrapper of an abstract event listener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

index 020cd3c3cf4e696bd93e18ae3204448ef1adf080..13c80058cff62d3b337fc533abe6fa84c1059346 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp

@@ -55,10 +55,6 @@ V8AbstractEventListener::V8AbstractEventListener(bool isAttribute, DOMWrapperWor

V8AbstractEventListener::~V8AbstractEventListener()

{

- if (!m_listener.isEmpty()) {

- v8::HandleScope scope(m_isolate);

- V8EventListenerList::clearWrapper(m_listener.newLocal(isolate()), m_isAttribute, isolate());

- }

if (isMainThread())

InstanceCounters::decrementCounter(InstanceCounters::JSEventListenerCounter);

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h » ('j') | no next file with comments »