third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h - Issue 1422573009: Don't bother clearing the wrapper of an abstract event listener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

Issue 1422573009: Don't bother clearing the wrapper of an abstract event listener (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

index b3de61342c043cbe58a4367bdc41f91ab218d5c5..b584237b6a98567df162c3abe9723f14308705cb 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListenerList.h

@@ -61,12 +61,6 @@ public:

template<typename WrapperType>

static PassRefPtrWillBeRawPtr<V8EventListener> findOrCreateWrapper(v8::Local<v8::Value>, bool isAttribute, ScriptState*);

- static void clearWrapper(v8::Local<v8::Object> listenerObject, bool isAttribute, v8::Isolate* isolate)

- {

- v8::Local<v8::String> wrapperProperty = getHiddenProperty(isAttribute, isolate);

- V8HiddenValue::deleteHiddenValue(isolate, listenerObject, wrapperProperty);

- }

CORE_EXPORT static PassRefPtrWillBeRawPtr<EventListener> getEventListener(ScriptState*, v8::Local<v8::Value>, bool isAttribute, ListenerLookupType);

private:

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp ('k') | no next file » | no next file with comments »