Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422333008: Remove Windows-related GN build configuration (Closed)

Created:
5 years, 1 month ago by Petr Hosek
Modified:
5 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove Windows-related GN build configuration We need longer support building Mojo on Windows so it doesn't make sense to keep the Windows build configuration around. BUG=#511 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/58ce0b715b452e011bb837546ee0da2b72f803e6

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Review feedback addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -1706 lines) Patch
M build/config/BUILD.gn View 2 chunks +3 lines, -43 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 3 chunks +4 lines, -20 lines 0 comments Download
M build/config/allocator.gni View 1 chunk +1 line, -2 lines 0 comments Download
M build/config/chrome_build.gni View 1 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 16 chunks +212 lines, -504 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/features.gni View 6 chunks +7 lines, -7 lines 0 comments Download
M build/config/ui.gni View 3 chunks +4 lines, -4 lines 0 comments Download
D build/config/win/BUILD.gn View 1 chunk +0 lines, -181 lines 0 comments Download
D build/config/win/visual_studio_version.gni View 1 chunk +0 lines, -39 lines 0 comments Download
M build/sanitizers/BUILD.gn View 1 chunk +6 lines, -15 lines 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M build/secondary/third_party/libjpeg_turbo/BUILD.gn View 2 chunks +1 line, -12 lines 0 comments Download
M build/secondary/third_party/libsrtp/BUILD.gn View 2 chunks +185 lines, -199 lines 0 comments Download
M build/secondary/third_party/nss/BUILD.gn View 11 chunks +28 lines, -154 lines 0 comments Download
M build/toolchain/goma.gni View 1 chunk +2 lines, -8 lines 0 comments Download
M build/toolchain/toolchain.gni View 1 chunk +0 lines, -2 lines 0 comments Download
D build/toolchain/win/BUILD.gn View 1 chunk +0 lines, -247 lines 0 comments Download
D build/toolchain/win/midl.gni View 1 chunk +0 lines, -105 lines 0 comments Download
D build/toolchain/win/setup_toolchain.py View 1 chunk +0 lines, -154 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Petr Hosek
5 years, 1 month ago (2015-11-06 00:55:40 UTC) #3
jamesr
lgtm https://codereview.chromium.org/1422333008/diff/20001/build/config/chrome_build.gni File build/config/chrome_build.gni (right): https://codereview.chromium.org/1422333008/diff/20001/build/config/chrome_build.gni#newcode21 build/config/chrome_build.gni:21: #is_multi_dll_chrome = false delete? https://codereview.chromium.org/1422333008/diff/20001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): ...
5 years, 1 month ago (2015-11-09 17:41:58 UTC) #4
Petr Hosek
https://codereview.chromium.org/1422333008/diff/20001/build/config/chrome_build.gni File build/config/chrome_build.gni (right): https://codereview.chromium.org/1422333008/diff/20001/build/config/chrome_build.gni#newcode21 build/config/chrome_build.gni:21: #is_multi_dll_chrome = false On 2015/11/09 17:41:58, jamesr wrote: > ...
5 years, 1 month ago (2015-11-10 01:35:54 UTC) #5
Petr Hosek
5 years, 1 month ago (2015-11-10 22:59:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
58ce0b715b452e011bb837546ee0da2b72f803e6.

Powered by Google App Engine
This is Rietveld 408576698