build/config/chrome_build.gni - Issue 1422333008: Remove Windows-related GN build configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/chrome_build.gni

Issue 1422333008: Remove Windows-related GN build configuration (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Review feedback addressed Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/chrome_build.gni

diff --git a/build/config/chrome_build.gni b/build/config/chrome_build.gni

index e2ff123543c61c474888854cb24fc3506f08a7df..aa63f1aa88a873e98487dd997e32e2464724c1c5 100644

--- a/build/config/chrome_build.gni

+++ b/build/config/chrome_build.gni

@@ -14,9 +14,4 @@ declare_args() {

# resources).

# TODO(brettw) move here from BUILDCONFIG.gn when DEPS are updated.

#is_chrome_branded = false

- # Break chrome.dll into multple pieces based on process type. Only available

- # on Windows.

- # TODO(brettw) make this work. When it does, the declaration should be:

- is_multi_dll_chrome = is_win && !is_component_build

}

« no previous file with comments | « build/config/allocator.gni ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »