build/toolchain/toolchain.gni - Issue 1422333008: Remove Windows-related GN build configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/toolchain.gni

Issue 1422333008: Remove Windows-related GN build configuration (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Review feedback addressed Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/toolchain.gni

diff --git a/build/toolchain/toolchain.gni b/build/toolchain/toolchain.gni

index 5bd7d9c714bf6928c4e373da0093fb5e2e096496..be5a22e8487c4feb1a2c4d685e1590ebca78ecbf 100644

--- a/build/toolchain/toolchain.gni

+++ b/build/toolchain/toolchain.gni

@@ -26,8 +26,6 @@ if (is_mac || is_ios) {

shlib_extension = ".cr.so"

} else if (is_posix) {

shlib_extension = ".so"

-} else if (is_win) {

- shlib_extension = ".dll"

} else {

assert(false, "Platform not supported")

}

« no previous file with comments | « build/toolchain/goma.gni ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »