Issue 14221009: Rename RenderViewHostDelegate::RenderViewGone -> RenderViewTerminated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14221009: Rename RenderViewHostDelegate::RenderViewGone -> RenderViewTerminated (Closed)

Created:
7 years, 8 months ago by Paweł Hajdan Jr.

Modified:
7 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename RenderViewHostDelegate::RenderViewGone -> RenderViewTerminated This helps avoid a collision with WebContentsObserver::RenderViewGone, preventing a class from inheriting both RenderViewHostDelegate and WebContentsObserver. BUG=170921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195542

Patch Set 1 #

Patch Set 2 : compile fix #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -23 lines)			Patch
M	content/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/interstitial_page_impl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/interstitial_page_impl.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl_unittest.cc	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

FYI I had to fix content/browser/web_contents/web_contents_impl_unittest.cc (compile fix) - feel free to take another look.

7 years, 8 months ago (2013-04-19 23:15:14 UTC) #3

Paweł Hajdan Jr.

7 years, 8 months ago (2013-04-22 17:34:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r195542 (presubmit successful).

Expand Messages | Collapse Messages