Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 14221009: Rename RenderViewHostDelegate::RenderViewGone -> RenderViewTerminated (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: compile fix Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index 81e61868d04f2528d9a3b650d699b3b407640c0e..cb702a4c978d89a021a26165ee655695e48e9df2 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -156,8 +156,9 @@ class TestInterstitialPage : public InterstitialPageImpl {
DidNavigate(GetRenderViewHostForTesting(), params);
}
- void TestRenderViewGone(base::TerminationStatus status, int error_code) {
- RenderViewGone(GetRenderViewHostForTesting(), status, error_code);
+ void TestRenderViewTerminated(base::TerminationStatus status,
+ int error_code) {
+ RenderViewTerminated(GetRenderViewHostForTesting(), status, error_code);
}
bool is_showing() const {
@@ -1806,7 +1807,7 @@ TEST_F(WebContentsImplTest, InterstitialCrasher) {
TestInterstitialPageStateGuard state_guard(interstitial);
interstitial->Show();
// Simulate a renderer crash before the interstitial is shown.
- interstitial->TestRenderViewGone(
+ interstitial->TestRenderViewTerminated(
base::TERMINATION_STATUS_PROCESS_CRASHED, -1);
// The interstitial should have been dismissed.
EXPECT_EQ(TestInterstitialPage::CANCELED, state);
@@ -1819,7 +1820,7 @@ TEST_F(WebContentsImplTest, InterstitialCrasher) {
interstitial->Show();
interstitial->TestDidNavigate(1, url);
// Simulate a renderer crash.
- interstitial->TestRenderViewGone(
+ interstitial->TestRenderViewTerminated(
base::TERMINATION_STATUS_PROCESS_CRASHED, -1);
// The interstitial should have been dismissed.
EXPECT_EQ(TestInterstitialPage::CANCELED, state);
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698