Implement chrome://network-errors for direct access to network error interstitials

content/browser/webui/url_data_manager_backend_unittest.cc

Index: content/browser/webui/url_data_manager_backend_unittest.cc
diff --git a/content/browser/webui/url_data_manager_backend_unittest.cc b/content/browser/webui/url_data_manager_backend_unittest.cc
index 9a511f1e25d98ccf08655c099363c570ee5ab068..fe8117d5aa0d7e89e405031505387dc621db2d55 100644
--- a/content/browser/webui/url_data_manager_backend_unittest.cc
+++ b/content/browser/webui/url_data_manager_backend_unittest.cc
@@ -107,4 +107,25 @@ TEST_F(UrlDataManagerBackendTest, CancelAfterFirstReadStarted) {
   EXPECT_EQ("", cancel_delegate.data_received());
 }
 
+// Check network error requests via chrome://network-error/.
+TEST_F(UrlDataManagerBackendTest, ChromeNetworkErrorPageRequest) {
+  scoped_ptr<net::URLRequest> request = url_request_context_.CreateRequest(
+        GURL("chrome://network-errors"), net::HIGHEST, &delegate_);
+  request->Start();
+  base::RunLoop().RunUntilIdle();

[mmenke, 2015/11/17 22:25:49]

Run() (The delegate exits the message loop when needed)

[edwardjung, 2015/11/19 13:43:29]

Thanks. Fixed.

+  EXPECT_TRUE(request->status().is_success());
+  EXPECT_TRUE(request->status().is_io_pending());
+  EXPECT_EQ(request->status().error(), net::OK);
+  EXPECT_EQ(request->status().status(), net::URLRequestStatus::SUCCESS);
+  EXPECT_NE(delegate_.data_received(), "");
+
+  scoped_ptr<net::URLRequest> error_request =

[mmenke, 2015/11/17 22:25:50]

Suggest just moving this into a separate test.  Fewer issues to worry about
(You're using the wrong request in the lines below this point).

[edwardjung, 2015/11/19 13:43:29]

Done.

+        url_request_context_.CreateRequest(
+        GURL("chrome://network-errors/-105"), net::HIGHEST, &delegate_);
+  request->Start();
+  base::RunLoop().RunUntilIdle();

[mmenke, 2015/11/17 22:25:49]

Run()

[edwardjung, 2015/11/19 13:43:29]

Done.

+  EXPECT_EQ(request->status().status(), net::URLRequestStatus::FAILED);
+  EXPECT_EQ(request->status().error(), net::ERR_NAME_NOT_RESOLVED);
+}
+

[mmenke, 2015/11/17 22:25:49]

Add a test with a URL with an invalid error code?

GURL("chrome://network-errors/-123456789");?

[edwardjung, 2015/11/19 13:43:29]

Done.

 }  // namespace content