Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: content/browser/webui/url_data_manager_backend.cc

Issue 1421743002: Implement chrome://network-errors for direct access to network error interstitials (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webui/url_data_manager_backend.cc
diff --git a/content/browser/webui/url_data_manager_backend.cc b/content/browser/webui/url_data_manager_backend.cc
index ac346dda7ca827cb786eabfff9963a3d313a1310..91d1dacfed8cd2be2cbc72979d08164134b4d148 100644
--- a/content/browser/webui/url_data_manager_backend.cc
+++ b/content/browser/webui/url_data_manager_backend.cc
@@ -23,6 +23,7 @@
#include "base/trace_event/trace_event.h"
#include "content/browser/fileapi/chrome_blob_storage_context.h"
#include "content/browser/histogram_internals_request_job.h"
+#include "content/browser/net/network_error_request_job.h"
#include "content/browser/net/view_blob_internals_job_factory.h"
#include "content/browser/net/view_http_cache_job_factory.h"
#include "content/browser/resource_context_impl.h"
@@ -507,6 +508,12 @@ class ChromeProtocolHandler
return new HistogramInternalsRequestJob(request, network_delegate);
}
+ // Check for chrome://network-errors/, which uses its own job type.
+ if (request->url().SchemeIs(kChromeUIScheme) &&
+ request->url().host() == kChromeUINetworkErrorHost) {
+ return new NetworkErrorRequestJob(request, network_delegate);
+ }
+
// Fall back to using a custom handler
return new URLRequestChromeJob(
request, network_delegate,

Powered by Google App Engine
This is Rietveld 408576698