Implement chrome://network-errors for direct access to network error interstitials

content/browser/webui/url_data_manager_backend_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "content/browser/webui/url_data_manager_backend.h"
 #include "content/public/test/mock_resource_context.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/http/http_response_headers.h"
@@ skipping 89 matching lines @@
   scoped_ptr<net::URLRequest> request(
       CreateRequest(&cancel_delegate, "chrome://webui"));
   request->Start();
   base::RunLoop().RunUntilIdle();
 
   EXPECT_EQ(net::URLRequestStatus::CANCELED, request->status().status());
   EXPECT_EQ(1, cancel_delegate.response_started_count());
   EXPECT_EQ("", cancel_delegate.data_received());
 }
 
+// Check network error requests via chrome://network-error/.
+TEST_F(UrlDataManagerBackendTest, ChromeNetworkErrorPageRequest) {
+  scoped_ptr<net::URLRequest> request = url_request_context_.CreateRequest(
+        GURL("chrome://network-errors"), net::HIGHEST, &delegate_);
+  request->Start();
+  base::RunLoop().RunUntilIdle();

[mmenke, 2015/11/17 22:25:49]

Run() (The delegate exits the message loop when needed)

[edwardjung, 2015/11/19 13:43:29]

Thanks. Fixed.

+  EXPECT_TRUE(request->status().is_success());
+  EXPECT_TRUE(request->status().is_io_pending());
+  EXPECT_EQ(request->status().error(), net::OK);
+  EXPECT_EQ(request->status().status(), net::URLRequestStatus::SUCCESS);
+  EXPECT_NE(delegate_.data_received(), "");
+
+  scoped_ptr<net::URLRequest> error_request =

[mmenke, 2015/11/17 22:25:50]

Suggest just moving this into a separate test.  Fewer issues to worry about
(You're using the wrong request in the lines below this point).

[edwardjung, 2015/11/19 13:43:29]

Done.

+        url_request_context_.CreateRequest(
+        GURL("chrome://network-errors/-105"), net::HIGHEST, &delegate_);
+  request->Start();
+  base::RunLoop().RunUntilIdle();

[mmenke, 2015/11/17 22:25:49]

Run()

[edwardjung, 2015/11/19 13:43:29]

Done.

+  EXPECT_EQ(request->status().status(), net::URLRequestStatus::FAILED);
+  EXPECT_EQ(request->status().error(), net::ERR_NAME_NOT_RESOLVED);
+}
+

[mmenke, 2015/11/17 22:25:49]

Add a test with a URL with an invalid error code?

GURL("chrome://network-errors/-123456789");?

[edwardjung, 2015/11/19 13:43:29]

Done.

 }  // namespace content