ui/views/controls/scrollbar/base_scroll_bar_button.cc - Issue 1421713002: Explicitly convert Point to PointF for event code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/scrollbar/base_scroll_bar_button.cc

Issue 1421713002: Explicitly convert Point to PointF for event code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wip

Patch Set: pointfconvert-prod: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/scrollbar/base_scroll_bar_button.cc

diff --git a/ui/views/controls/scrollbar/base_scroll_bar_button.cc b/ui/views/controls/scrollbar/base_scroll_bar_button.cc

index 54dbe7501ee01024757816a651bf9ceafcaddc79..58c5de999ecfeb3b583b97d3e2e1e27c0b34e1e8 100644

--- a/ui/views/controls/scrollbar/base_scroll_bar_button.cc

+++ b/ui/views/controls/scrollbar/base_scroll_bar_button.cc

@@ -39,9 +39,9 @@ void BaseScrollBarButton::RepeaterNotifyClick() {

// TODO(scottmg): Native is wrong: http://crbug.com/133312

gfx::Point cursor_point =

gfx::Screen::GetNativeScreen()->GetCursorScreenPoint();

- ui::MouseEvent event(ui::ET_MOUSE_RELEASED, cursor_point, cursor_point,

- ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON,

- ui::EF_LEFT_MOUSE_BUTTON);

+ ui::MouseEvent event(ui::ET_MOUSE_RELEASED, gfx::PointF(cursor_point),

+ gfx::PointF(cursor_point), ui::EventTimeForNow(),

+ ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON);

Button::NotifyClick(event);

}