ui/views/controls/scrollbar/base_scroll_bar_button.cc - Issue 1421713002: Explicitly convert Point to PointF for event code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/controls/scrollbar/base_scroll_bar_button.cc

Issue 1421713002: Explicitly convert Point to PointF for event code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wip

Patch Set: pointfconvert-prod: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ui/views/controls/menu/menu_message_loop_aura.cc ('k') | ui/views/controls/textfield/textfield.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/views/controls/scrollbar/base_scroll_bar_button.h"	5 #include "ui/views/controls/scrollbar/base_scroll_bar_button.h"

6	6

7 #include "base/bind.h"	7 #include "base/bind.h"

8 #include "base/bind_helpers.h"	8 #include "base/bind_helpers.h"

9 #include "ui/events/event_utils.h"	9 #include "ui/events/event_utils.h"

10 #include "ui/gfx/screen.h"	10 #include "ui/gfx/screen.h"

(...skipping 21 matching lines...) Expand all Loading...
32	32

33 void BaseScrollBarButton::OnMouseCaptureLost() {	33 void BaseScrollBarButton::OnMouseCaptureLost() {

34 repeater_.Stop();	34 repeater_.Stop();

35 }	35 }

36	36

37 void BaseScrollBarButton::RepeaterNotifyClick() {	37 void BaseScrollBarButton::RepeaterNotifyClick() {

38 // TODO(sky): See if we can convert to using \|Screen\| everywhere.	38 // TODO(sky): See if we can convert to using \|Screen\| everywhere.

39 // TODO(scottmg): Native is wrong: http://crbug.com/133312	39 // TODO(scottmg): Native is wrong: http://crbug.com/133312

40 gfx::Point cursor_point =	40 gfx::Point cursor_point =

41 gfx::Screen::GetNativeScreen()->GetCursorScreenPoint();	41 gfx::Screen::GetNativeScreen()->GetCursorScreenPoint();

42 ui::MouseEvent event(ui::ET_MOUSE_RELEASED, cursor_point, cursor_point,	42 ui::MouseEvent event(ui::ET_MOUSE_RELEASED, gfx::PointF(cursor_point),

43 ui::EventTimeForNow(), ui::EF_LEFT_MOUSE_BUTTON,	43 gfx::PointF(cursor_point), ui::EventTimeForNow(),

44 ui::EF_LEFT_MOUSE_BUTTON);	44 ui::EF_LEFT_MOUSE_BUTTON, ui::EF_LEFT_MOUSE_BUTTON);

45 Button::NotifyClick(event);	45 Button::NotifyClick(event);

46 }	46 }

47	47

48 } // namespace views	48 } // namespace views

OLD	NEW