ui/views/controls/menu/menu_message_loop_aura.cc - Issue 1421713002: Explicitly convert Point to PointF for event code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_message_loop_aura.cc

Issue 1421713002: Explicitly convert Point to PointF for event code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wip

Patch Set: pointfconvert-prod: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_message_loop_aura.cc

diff --git a/ui/views/controls/menu/menu_message_loop_aura.cc b/ui/views/controls/menu/menu_message_loop_aura.cc

index 8ad00e8458de7e1fba6a37b3212df125f8008f77..f1171c87fabebee8a486e2ad572e5164bf46dae8 100644

--- a/ui/views/controls/menu/menu_message_loop_aura.cc

+++ b/ui/views/controls/menu/menu_message_loop_aura.cc

@@ -116,8 +116,8 @@ void MenuMessageLoopAura::RepostEventToWindow(const ui::LocatedEvent& event,

spc->ConvertPointFromScreen(root, &root_loc);

ui::MouseEvent clone(static_cast<const ui::MouseEvent&>(event));

- clone.set_location(root_loc);

- clone.set_root_location(root_loc);

+ clone.set_location(gfx::PointF(root_loc));

+ clone.set_root_location(gfx::PointF(root_loc));

root->GetHost()->dispatcher()->RepostEvent(clone);

}