Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h

Issue 14215009: Changed cloud print private API to pass all page settings as single object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed warning and unittes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h
diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h
index a2b87bfeb576cb1374d7e227f4466cc0ebd6a087..25e30c9248cf26d065c3b14af7056541fdab8c20 100644
--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h
+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h
@@ -12,6 +12,17 @@
namespace extensions {
+namespace api {
+
asargent_no_longer_on_chrome 2013/04/17 19:05:04 optional suggestion: remove this blank line
Vitaly Buka (NO REVIEWS) 2013/04/18 00:00:11 Done.
+namespace cloud_print_private {
+
+struct UserSettings;
+
+} // namespace cloud_print_private
+
asargent_no_longer_on_chrome 2013/04/17 19:05:04 this one too
Vitaly Buka (NO REVIEWS) 2013/04/18 00:00:11 Done.
+} // namespace api
+
+
// For use only in tests.
class CloudPrintTestsDelegate {
public:
@@ -22,8 +33,7 @@ class CloudPrintTestsDelegate {
const std::string& user_email,
const std::string& robot_email,
const std::string& credentials,
- bool connect_new_printers,
- const std::vector<std::string>& printer_blacklist) = 0;
+ const api::cloud_print_private::UserSettings& user_settings) = 0;
virtual std::string GetHostName() = 0;

Powered by Google App Engine
This is Rietveld 408576698