Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2334)

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

Issue 14215009: Changed cloud print private API to pass all page settings as single object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed warning and unittes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
index 7c4343ed323c299fbcedbfaa800f95bed0f24308..e055e592a27274d865dea80486382bc145393b3a 100644
--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc
@@ -29,6 +29,7 @@ CloudPrintTestsDelegate::~CloudPrintTestsDelegate() {
instance_ = NULL;
}
+
CloudPrintPrivateSetupConnectorFunction::
CloudPrintPrivateSetupConnectorFunction() {
}
@@ -46,17 +47,17 @@ bool CloudPrintPrivateSetupConnectorFunction::RunImpl() {
params->user_email,
params->robot_email,
params->credentials,
- params->connect_new_printers,
- params->printer_blacklist);
+ params->user_settings);
} else {
if (!CloudPrintProxyServiceFactory::GetForProfile(profile_))
return false;
+ scoped_ptr<base::DictionaryValue> user_setings(
+ params->user_settings.ToValue());
CloudPrintProxyServiceFactory::GetForProfile(profile_)->
EnableForUserWithRobot(params->credentials,
params->robot_email,
params->user_email,
- params->connect_new_printers,
- params->printer_blacklist);
+ *user_setings);
}
SendResponse(true);
return true;

Powered by Google App Engine
This is Rietveld 408576698