Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3298)

Unified Diff: chrome/common/extensions/api/cloud_print_private.json

Issue 14215009: Changed cloud print private API to pass all page settings as single object. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed warning and unittes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/cloud_print_private.json
diff --git a/chrome/common/extensions/api/cloud_print_private.json b/chrome/common/extensions/api/cloud_print_private.json
index ca2c6a3abf2d30c8c7c1f18b8c749f35f3703990..9b25844b8263b7bf911804e709dab1668156216a 100644
--- a/chrome/common/extensions/api/cloud_print_private.json
+++ b/chrome/common/extensions/api/cloud_print_private.json
@@ -6,6 +6,48 @@
{
"namespace": "cloudPrintPrivate",
"nodoc": "true",
+ "types": [
+ {
+ "id": "PrinterSettings",
+ "type": "object",
+ "description": "Settings per printer.",
+ "additionalProperties": { "type": "any" },
asargent_no_longer_on_chrome 2013/04/17 19:05:04 Did you actually need this to avoid validation err
Vitaly Buka (NO REVIEWS) 2013/04/18 00:00:11 Done.
+ "properties": {
+ "name": {
+ "type": "string",
+ "description": "Unique printer id."
+ },
+ "connect": {
+ "type": "boolean",
+ "description": "Whether printer is selected."
+ },
+ "displayName": {
+ "type": "string",
+ "optional": true,
+ "description": "Printer name visible to user."
+ }
+ }
+ },
+ {
+ "id": "UserSettings",
+ "type": "object",
+ "description": "Settings set by user.",
+ "additionalProperties": { "type": "any" },
+ "properties": {
+ "printers": {
+ "description": "Printer settings.",
+ "type": "array",
+ "items": {
+ "$ref": "PrinterSettings"
+ }
+ },
+ "connectNewPrinters": {
+ "type": "boolean",
+ "description": "Whether should printer be connected."
+ }
+ }
+ }
+ ],
"functions": [
{
"name": "setupConnector",
@@ -28,15 +70,9 @@
"description": "The login credentials(OAuth2 Auth code)."
},
{
- "name": "connectNewPrinters",
- "type": "boolean",
- "description": "True if new printers should be connected."
- },
- {
- "name": "printerBlacklist",
- "description": "Printers that should not be connected.",
- "type": "array",
- "items": {"type": "string"}
+ "name": "userSettings",
+ "$ref": "UserSettings",
+ "description": "Options configured by user."
}
]
},

Powered by Google App Engine
This is Rietveld 408576698