chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/trees/property_tree_builder.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | content/common/discardable_shared_memory_heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

index 96cd8b2197e5d8a2b3f5e1b020c291bd538e5670..e9e63896186e2b2f44b66f66b6571ed14a76d9e4 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

+++ b/chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc

@@ -127,7 +127,7 @@ class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {

content::WebContentsTester* web_contents_tester =

content::WebContentsTester::For(web_contents());

web_contents_tester->StartNavigation(url);

- DCHECK_IMPLIES(navigation_type == kSameProcess, !pending_main_rfh());

+ DCHECK(navigation_type != kSameProcess || !pending_main_rfh());

EXPECT_CALL(mock_reloader(), OnAbort()).Times(1);

content::RenderFrameHost* rfh =

@@ -156,7 +156,7 @@ class CaptivePortalTabHelperTest : public ChromeRenderViewHostTestHarness {