chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index 55525e256a558b440b04d717e0f1e5559233d66d..ea82411dae1028afb8ffe3b20b4eeba98e333f07 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -122,7 +122,7 @@ bool ManagePasswordsUIController::OnChooseCredentials(

ScopedVector<autofill::PasswordForm> federated_credentials,

const GURL& origin,

base::Callback<void(const password_manager::CredentialInfo&)> callback) {

- DCHECK_IMPLIES(local_credentials.empty(), !federated_credentials.empty());

+ DCHECK(!local_credentials.empty() || !federated_credentials.empty());

passwords_data_.OnRequestCredentials(local_credentials.Pass(),

federated_credentials.Pass(),

origin);