cc/trees/property_tree_builder.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/property_tree_builder.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/property_tree_builder.cc

diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc

index cf6ebb90b51140b83817837e3ab647414594c714..31edaebee779b1e683fe2d5408bc52293488e600 100644

--- a/cc/trees/property_tree_builder.cc

+++ b/cc/trees/property_tree_builder.cc

@@ -236,7 +236,7 @@ bool AddTransformNodeIfNeeded(

is_page_scale_layer;

LayerType* transform_parent = GetTransformParent(data_from_ancestor, layer);

- DCHECK_IMPLIES(!is_root, transform_parent);

+ DCHECK(is_root || transform_parent);

int parent_index = kRootPropertyTreeNodeId;

if (transform_parent)