Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2798)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 235817de449eceb01df10477a7aeb2e17bc726a6..c598dcdebbb488584325b973d5f5c06a00357fbc 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -477,8 +477,8 @@ void LayerTreeHostImpl::StartPageScaleAnimation(
}
void LayerTreeHostImpl::SetNeedsAnimateInput() {
- DCHECK_IMPLIES(IsCurrentlyScrollingInnerViewport(),
- !settings_.ignore_root_layer_flings);
+ DCHECK(!IsCurrentlyScrollingInnerViewport() ||
+ !settings_.ignore_root_layer_flings);
SetNeedsAnimate();
}
@@ -1019,7 +1019,7 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
// destroyed.
// TODO(weiliangc): Test copy request w/ output surface recreation. Would
// trigger this DCHECK.
- DCHECK_IMPLIES(have_copy_request, draw_result == DRAW_SUCCESS);
+ DCHECK(!have_copy_request || draw_result == DRAW_SUCCESS);
return draw_result;
}

Powered by Google App Engine
This is Rietveld 408576698