cc/trees/layer_tree_host_common.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_common.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host_common.cc

diff --git a/cc/trees/layer_tree_host_common.cc b/cc/trees/layer_tree_host_common.cc

index 40184b0de79d9eb738229a5679d21398ba965307..353d94f7a514e6c1d6f54470eb8dfe10eb981807 100644

--- a/cc/trees/layer_tree_host_common.cc

+++ b/cc/trees/layer_tree_host_common.cc

@@ -415,8 +415,8 @@ void UpdateAccumulatedSurfaceState(

current_target->render_surface()->draw_transform();

// If we have unclipped descendants, the draw transform is a translation.

- DCHECK_IMPLIES(current_target->num_unclipped_descendants(),

- current_draw_transform.IsIdentityOrTranslation());

+ DCHECK(!current_target->num_unclipped_descendants() ||

+ current_draw_transform.IsIdentityOrTranslation());

target_rect =

MathUtil::MapEnclosingClippedRect(current_draw_transform, target_rect);