Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: content/test/web_contents_observer_sanity_checker.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/test_web_contents.cc ('k') | gpu/command_buffer/service/mailbox_manager_sync.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/web_contents_observer_sanity_checker.cc
diff --git a/content/test/web_contents_observer_sanity_checker.cc b/content/test/web_contents_observer_sanity_checker.cc
index 2754ddeba4970367e297c5eb737e79a608faeff4..1935d2ecd5b1b175dd09b912c385879663dd6fa5 100644
--- a/content/test/web_contents_observer_sanity_checker.cc
+++ b/content/test/web_contents_observer_sanity_checker.cc
@@ -157,16 +157,16 @@ void WebContentsObserverSanityChecker::DidFinishNavigation(
NavigationHandle* navigation_handle) {
CHECK(NavigationIsOngoing(navigation_handle));
- CHECK_IMPLIES(
- navigation_handle->HasCommitted() && !navigation_handle->IsErrorPage(),
- navigation_handle->GetNetErrorCode() == net::OK);
- CHECK_IMPLIES(
- navigation_handle->HasCommitted() && navigation_handle->IsErrorPage(),
- navigation_handle->GetNetErrorCode() != net::OK);
+ CHECK(!(navigation_handle->HasCommitted() &&
+ !navigation_handle->IsErrorPage()) ||
+ navigation_handle->GetNetErrorCode() == net::OK);
+ CHECK(!(navigation_handle->HasCommitted() &&
+ navigation_handle->IsErrorPage()) ||
+ navigation_handle->GetNetErrorCode() != net::OK);
CHECK_EQ(navigation_handle->GetWebContents(), web_contents());
- CHECK_IMPLIES(navigation_handle->HasCommitted(),
- navigation_handle->GetRenderFrameHost() != nullptr);
+ CHECK(!navigation_handle->HasCommitted() ||
+ navigation_handle->GetRenderFrameHost() != nullptr);
ongoing_navigations_.erase(navigation_handle);
}
« no previous file with comments | « content/test/test_web_contents.cc ('k') | gpu/command_buffer/service/mailbox_manager_sync.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698