content/test/test_web_contents.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_web_contents.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/test_web_contents.cc

diff --git a/content/test/test_web_contents.cc b/content/test/test_web_contents.cc

index 3ba7aee83e6fb2a1a5d6fd4cf9185acef4e77bd1..788081a6559d95ea02e580228c474fc7c8f61e0e 100644

--- a/content/test/test_web_contents.cc

+++ b/content/test/test_web_contents.cc

@@ -227,9 +227,9 @@ void TestWebContents::CommitPendingNavigation() {

TestRenderFrameHost* rfh = GetPendingMainFrame();

if (!rfh)

rfh = old_rfh;

- CHECK_IMPLIES(browser_side_navigation, rfh->is_loading());

- CHECK_IMPLIES(browser_side_navigation,

- !rfh->frame_tree_node()->navigation_request());

+ CHECK(!browser_side_navigation || rfh->is_loading());

+ CHECK(!browser_side_navigation ||

+ !rfh->frame_tree_node()->navigation_request());

int page_id = entry->GetPageID();

if (page_id == -1) {