gpu/command_buffer/service/mailbox_manager_sync.cc - Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/mailbox_manager_sync.cc

Issue 1421483005: Reland: Remove DCHECK_IMPLIES/CHECK_IMPLIES. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/mailbox_manager_sync.cc

diff --git a/gpu/command_buffer/service/mailbox_manager_sync.cc b/gpu/command_buffer/service/mailbox_manager_sync.cc

index a48d032e6e2a28b18334ee6f2445c63cde509f12..94aa1d7a59dd5d6ff21c3cf8210d1bf498992d7a 100644

--- a/gpu/command_buffer/service/mailbox_manager_sync.cc

+++ b/gpu/command_buffer/service/mailbox_manager_sync.cc

@@ -287,7 +287,7 @@ void MailboxManagerSync::UpdateDefinitionLocked(

if (definition.Matches(texture))

return;

- DCHECK_IMPLIES(image, image_buffer.get());

+ DCHECK(!image || image_buffer.get());

if (image && !image_buffer->IsClient(image)) {

LOG(ERROR) << "MailboxSync: Incompatible attachment";

return;