Issue 1421283004: Review helper for https://codereview.chromium.org/1409073013

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1421283004: Review helper for https://codereview.chromium.org/1409073013 (Closed)

Created:
5 years, 1 month ago by Mark Mentovai

Modified:
5 years, 1 month ago

Reviewers:

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Review helper for https://codereview.chromium.org/1409073013 NOT FOR CHECKIN

Patch Set 1 #

Patch Set 2 : unindent #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -91 lines)			Patch
M	client/crashpad_client_mac.cc	View	1	8 chunks	+127 lines, -33 lines	0 comments	Download
M	handler/mac/exception_handler_server.h	View		2 chunks	+13 lines, -15 lines	0 comments	Download
M	handler/mac/exception_handler_server.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	handler/main.cc	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	snapshot/win/exception_snapshot_win_test.cc	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	util/mach/child_port_handshake.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	util/mach/mach_message_server.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	util/win/exception_handler_server.h	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	util/win/exception_handler_server.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	util/win/exception_handler_server_test.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

5 years, 1 month ago (2015-10-29 21:52:45 UTC) #1

Description was changed from

==========
Review helper for https://codereview.chromium.org/1409073013
==========

to

==========
Review helper for https://codereview.chromium.org/1409073013

NOT FOR CHECKIN
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages