util/mach/child_port_handshake.h - Issue 1421283004: Review helper for https://codereview.chromium.org/1409073013

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/mach/child_port_handshake.h

Issue 1421283004: Review helper for https://codereview.chromium.org/1409073013 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: unindent Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: util/mach/child_port_handshake.h

diff --git a/util/mach/child_port_handshake.h b/util/mach/child_port_handshake.h

index c1d7ab9a592d3a306faedbe4eb1a0ebd58aa7031..5110e1dfd2b1ddba8c3386fa1a1023df90080b9c 100644

--- a/util/mach/child_port_handshake.h

+++ b/util/mach/child_port_handshake.h

@@ -122,7 +122,7 @@ class ChildPortHandshakeTest;

//!

//! // Send the receive right to the child process, retaining the send right

//! // for use in the parent process.

-//! if (child_port_handshake.RunClient(receive_right,

+//! if (child_port_handshake.RunClient(receive_right.get(),

//! MACH_MSG_TYPE_MOVE_RECEIVE)) {

//! ignore_result(receive_right.release());

//! }

« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/mach/mach_message_server.h » ('j') | no next file with comments »