Chromium Code Reviews Chromium Code Reviews
Issue
1409073013:
mac: Make crashpad_handler get its receive right from its client (Closed)
Descriptionmac: Make crashpad_handler get its receive right from its client
Previously, crashpad_handler made its own receive right, and transferred
a corresponding send right to its client. There are two advantages to
making the receive right in the client:
- It is possible to monitor the receive right for a port-destroyed
notificaiton in the client, allowing the handler to be restarted if
it dies.
- For the future run-from-launchd mode (bug crashpad:25), the handler
will obtain its receive right from the bootstrap server instead of
making its own. Having the handler get its receive right from
different sources allows more code to be shared than if it were to
sometimes get a receive right and sometimes make a receive right and
transfer a send right.
This includes a restructuring in crashpad_client_mac.cc that will make
it easier to give it an option to restart crashpad_handler if it dies.
The handler starting logic should all behave the same as before.
BUG=crashpad:68
R=rsesek@chromium.org
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/fc7d8b3a27e10bfd400256b941353736383c0979
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 2
Patch Set 3 : Revise documentation #Patch Set 4 : Fix the example some more #Patch Set 5 : #
Messages
Total messages: 7 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
