Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1409073013: mac: Make crashpad_handler get its receive right from its client (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

mac: Make crashpad_handler get its receive right from its client Previously, crashpad_handler made its own receive right, and transferred a corresponding send right to its client. There are two advantages to making the receive right in the client: - It is possible to monitor the receive right for a port-destroyed notificaiton in the client, allowing the handler to be restarted if it dies. - For the future run-from-launchd mode (bug crashpad:25), the handler will obtain its receive right from the bootstrap server instead of making its own. Having the handler get its receive right from different sources allows more code to be shared than if it were to sometimes get a receive right and sometimes make a receive right and transfer a send right. This includes a restructuring in crashpad_client_mac.cc that will make it easier to give it an option to restart crashpad_handler if it dies. The handler starting logic should all behave the same as before. BUG=crashpad:68 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/fc7d8b3a27e10bfd400256b941353736383c0979

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Revise documentation #

Patch Set 4 : Fix the example some more #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -179 lines) Patch
M client/crashpad_client_mac.cc View 2 chunks +199 lines, -118 lines 0 comments Download
M handler/mac/exception_handler_server.h View 1 2 2 chunks +13 lines, -15 lines 0 comments Download
M handler/mac/exception_handler_server.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M handler/main.cc View 1 2 chunks +9 lines, -8 lines 0 comments Download
M snapshot/win/exception_snapshot_win_test.cc View 1 3 chunks +11 lines, -7 lines 0 comments Download
M util/mach/child_port_handshake.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M util/mach/mach_message_server.h View 1 chunk +2 lines, -2 lines 0 comments Download
M util/win/exception_handler_server.h View 1 2 chunks +4 lines, -7 lines 0 comments Download
M util/win/exception_handler_server.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M util/win/exception_handler_server_test.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Mark Mentovai
5 years, 1 month ago (2015-10-29 19:12:02 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/1409073013/diff/20001/handler/mac/exception_handler_server.h File handler/mac/exception_handler_server.h (right): https://codereview.chromium.org/1409073013/diff/20001/handler/mac/exception_handler_server.h#newcode31 handler/mac/exception_handler_server.h:31: explicit ExceptionHandlerServer( No comment?
5 years, 1 month ago (2015-10-29 21:04:00 UTC) #3
Mark Mentovai
https://codereview.chromium.org/1409073013/diff/20001/handler/mac/exception_handler_server.h File handler/mac/exception_handler_server.h (right): https://codereview.chromium.org/1409073013/diff/20001/handler/mac/exception_handler_server.h#newcode31 handler/mac/exception_handler_server.h:31: explicit ExceptionHandlerServer( Robert Sesek wrote: > No comment? Good ...
5 years, 1 month ago (2015-10-29 21:39:58 UTC) #4
Mark Mentovai
Note that I made a “review helper” CL at https://codereview.chromium.org/1421283004 by putting the moved content ...
5 years, 1 month ago (2015-10-29 21:52:36 UTC) #5
Robert Sesek
slgtm
5 years, 1 month ago (2015-10-29 22:08:05 UTC) #6
Mark Mentovai
5 years, 1 month ago (2015-10-29 22:09:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
fc7d8b3a27e10bfd400256b941353736383c0979 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698