Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1421123002: Revert of Reland "Use C++ implementation of Object.definePropert{y,ies}" (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Use C++ implementation of Object.definePropert{y,ies}" (patchset #2 id:20001 of https://codereview.chromium.org/1413123004/ ) Reason for revert: Breaks test if rolled into Chromium: http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20%281%29&number=60441 Original issue's description: > Reland "Use C++ implementation of Object.definePropert{y,ies}" > > This reverts commit 581ead5c8ceeb0e4ee2049d78972418236f5d3ba. > > Committed: https://crrev.com/034f4a6ae14cd5c29ceddbdb8f9af179803ca793 > Cr-Commit-Position: refs/heads/master@{#31473} TBR=verwaest@chromium.org,jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0188aeadbbb9678eb11223a53d0bbb12d2f07ab9 Cr-Commit-Position: refs/heads/master@{#31535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -101 lines) Patch
M src/js/v8natives.js View 2 chunks +48 lines, -58 lines 0 comments Download
M src/objects.cc View 6 chunks +6 lines, -28 lines 0 comments Download
M src/property-descriptor.cc View 3 chunks +1 line, -9 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Hablich
Created Revert of Reland "Use C++ implementation of Object.definePropert{y,ies}"
5 years, 2 months ago (2015-10-23 19:23:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1421123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1421123002/1
5 years, 2 months ago (2015-10-23 19:24:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 19:24:11 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 19:24:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0188aeadbbb9678eb11223a53d0bbb12d2f07ab9
Cr-Commit-Position: refs/heads/master@{#31535}

Powered by Google App Engine
This is Rietveld 408576698