Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: src/property-descriptor.cc

Issue 1421123002: Revert of Reland "Use C++ implementation of Object.definePropert{y,ies}" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property-descriptor.cc
diff --git a/src/property-descriptor.cc b/src/property-descriptor.cc
index 2ecf75a74e593f37587ffb337d81bbe4e8b3dd68..442d056a1c081a6ca22b78ccbfcd5ef8dc056dbc 100644
--- a/src/property-descriptor.cc
+++ b/src/property-descriptor.cc
@@ -4,7 +4,6 @@
#include "src/property-descriptor.h"
-#include "src/bootstrapper.h"
#include "src/factory.h"
#include "src/isolate-inl.h"
#include "src/lookup.h"
@@ -44,9 +43,6 @@
if (map->instance_type() != JS_OBJECT_TYPE) return false;
if (map->is_access_check_needed()) return false;
if (map->prototype() != *isolate->initial_object_prototype()) return false;
- // During bootstrapping, the object_function_prototype_map hasn't been
- // set up yet.
- if (isolate->bootstrapper()->IsActive()) return false;
if (JSObject::cast(map->prototype())->map() !=
isolate->native_context()->object_function_prototype_map()) {
return false;
@@ -214,11 +210,7 @@
}
} else {
DCHECK(obj->IsJSProxy());
- // Having an UNIMPLEMENTED() here would upset ClusterFuzz, because
- // --harmony-proxies makes it possible to reach this branch.
- isolate->Throw(
- *isolate->factory()->NewTypeError(MessageTemplate::kUnsupported));
- return false;
+ UNIMPLEMENTED();
}
// 23. Return desc.
return true;
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698