Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1413123004: Reland "Use C++ implementation of Object.definePropert{y,ies}" (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Use C++ implementation of Object.definePropert{y,ies}" This reverts commit 581ead5c8ceeb0e4ee2049d78972418236f5d3ba. Committed: https://crrev.com/034f4a6ae14cd5c29ceddbdb8f9af179803ca793 Cr-Commit-Position: refs/heads/master@{#31473}

Patch Set 1 : original patch #

Patch Set 2 : fixes for access checks and interceptors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -79 lines) Patch
M src/js/v8natives.js View 2 chunks +54 lines, -44 lines 0 comments Download
M src/objects.cc View 1 6 chunks +28 lines, -6 lines 0 comments Download
M src/property-descriptor.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
Here we go again.
5 years, 2 months ago (2015-10-22 11:43:01 UTC) #2
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-22 11:57:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413123004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413123004/20001
5 years, 2 months ago (2015-10-22 12:45:41 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 13:16:36 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/034f4a6ae14cd5c29ceddbdb8f9af179803ca793 Cr-Commit-Position: refs/heads/master@{#31473}
5 years, 2 months ago (2015-10-22 13:16:52 UTC) #7
Michael Hablich
5 years, 2 months ago (2015-10-23 19:23:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1421123002/ by hablich@chromium.org.

The reason for reverting is: Breaks test if rolled into Chromium:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Vista%20Tests%20....

Powered by Google App Engine
This is Rietveld 408576698