Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1421013003: [Merge in M47] Do not involve PasswordManagerDriver in filling HTTP-auth forms; also check realm (Closed)

Created:
5 years, 2 months ago by vabr (Chromium)
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, asanka, rouslan+autofill_chromium.org, benjhayden+dwatch_chromium.org, tfarina, vabr+watchlist_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

[Merge in M47] Do not involve PasswordManagerDriver in filling HTTP-auth forms; also check realm The HTTP authentication is not tied to a renderer and happens completely browser-side. This CL simplifies the password manager API for filling these forms to avoid referencing the renderer. It also enhances LoginModelObserver to filter irrelevant credentials by realm. BUG=537823 Review URL: https://codereview.chromium.org/1384283003 Cr-Commit-Position: refs/heads/master@{#352816} (cherry picked from commit e0e1e99f39349e912612e58249393f2281de4d00) Solved conflicts: components/password_manager/core/browser/password_manager.cc contained https://codereview.chromium.org/1402803002, the patch was adapted to match the current ToT for that. TBR=melandory@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a05f004a42db051ca1db0c2e8f065dc4b2d35ad7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -121 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 3 chunks +68 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/login_prompt_android.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/login_prompt_cocoa.mm View 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.h View 4 chunks +28 lines, -8 lines 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 11 chunks +38 lines, -35 lines 0 comments Download
M chrome/browser/ui/views/login_prompt_views.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/login_view.h View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/login_view.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/login_model.h View 1 chunk +43 lines, -10 lines 0 comments Download
A components/password_manager/core/browser/login_model.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A components/password_manager/core/browser/login_model_unittest.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 5 chunks +17 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.h View 1 chunk +8 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 5 chunks +52 lines, -36 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
5 years, 2 months ago (2015-10-23 09:26:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a05f004a42db051ca1db0c2e8f065dc4b2d35ad7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698