Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2725)

Unified Diff: chrome/browser/ui/android/login_prompt_android.cc

Issue 1421013003: [Merge in M47] Do not involve PasswordManagerDriver in filling HTTP-auth forms; also check realm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2526
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/login_prompt_android.cc
diff --git a/chrome/browser/ui/android/login_prompt_android.cc b/chrome/browser/ui/android/login_prompt_android.cc
index 7f478bf011463d244566bd656eda56b6c559b34f..367cb2c4d7086e2ebac97c74911614b169db43b7 100644
--- a/chrome/browser/ui/android/login_prompt_android.cc
+++ b/chrome/browser/ui/android/login_prompt_android.cc
@@ -10,7 +10,6 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/android/chrome_http_auth_handler.h"
#include "chrome/browser/ui/android/window_android_helper.h"
-#include "chrome/browser/ui/login/login_prompt.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "net/base/auth.h"
@@ -28,8 +27,9 @@ class LoginHandlerAndroid : public LoginHandler {
// LoginHandler methods:
- void OnAutofillDataAvailable(const base::string16& username,
- const base::string16& password) override {
+ void OnAutofillDataAvailableInternal(
+ const base::string16& username,
+ const base::string16& password) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(chrome_http_auth_handler_.get() != NULL);
chrome_http_auth_handler_->OnAutofillDataAvailable(
@@ -37,8 +37,8 @@ class LoginHandlerAndroid : public LoginHandler {
}
void OnLoginModelDestroying() override {}
- void BuildViewForPasswordManager(password_manager::PasswordManager* manager,
- const base::string16& explanation) override {
+ void BuildView(const base::string16& explanation,
+ LoginModelData* login_model_data) override {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
// Get pointer to TabAndroid
@@ -55,8 +55,11 @@ class LoginHandlerAndroid : public LoginHandler {
chrome_http_auth_handler_->ShowDialog(
window_helper->GetWindowAndroid()->GetJavaObject().obj());
- // Register to receive a callback to OnAutofillDataAvailable().
- SetModel(manager);
+ if (login_model_data)
+ SetModel(*login_model_data);
+ else
+ ResetModel();
+
NotifyAuthNeeded();
} else {
CancelAuth();
« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/browser/ui/cocoa/login_prompt_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698