components/password_manager/core/browser/password_manager.h - Issue 1421013003: [Merge in M47] Do not involve PasswordManagerDriver in filling HTTP-auth forms; also check realm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 1421013003: [Merge in M47] Do not involve PasswordManagerDriver in filling HTTP-auth forms; also check realm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2526

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.h

diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h

index 16bde656c8c113a194238d4278fef883501f8926..410bf3368c4879b2cbd1243fe6e114e2f9d2ee72 100644

--- a/components/password_manager/core/browser/password_manager.h

+++ b/components/password_manager/core/browser/password_manager.h

@@ -67,8 +67,15 @@ class PasswordManager : public LoginModel {

const autofill::PasswordForm& preferred_match,

bool wait_for_username) const;

+ // Called by a PasswordFormManager when it decides a HTTP auth dialog can be

+ // autofilled.

+ void AutofillHttpAuth(const autofill::PasswordFormMap& best_matches,

+ const autofill::PasswordForm& preferred_match) const;

// LoginModel implementation.

- void AddObserver(LoginModelObserver* observer) override;

+ void AddObserverAndDeliverCredentials(

+ LoginModelObserver* observer,

+ const autofill::PasswordForm& observed_form) override;

void RemoveObserver(LoginModelObserver* observer) override;

void GenerationAvailableForForm(const autofill::PasswordForm& form);