Simplify config for Clang ToT builders.

Simplify config for Clang ToT builders.

BUG=
R=thakis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297474

[pcc1, 2015-11-05 01:31:45]

I *think* this is ok. The only bots that actually change config are Windows bots
(which don't care about the value of clang_use_chrome_plugins) and an ASan
tester (which I believe doesn't build, and even if it did would probably want
clang_use_chrome_plugins=0 anyway).

[Nico, 2015-11-05 01:36:25]

On 2015/11/05 01:31:45, pcc1 wrote:
> I *think* this is ok. The only bots that actually change config are Windows
bots
> (which don't care about the value of clang_use_chrome_plugins)

They do care about this, it controls if the plugin is enabled (even though it's
always compiled in).

> and an ASan
> tester (which I believe doesn't build, and even if it did would probably want
> clang_use_chrome_plugins=0 anyway).

[pcc1, 2015-11-05 02:03:09]

On 2015/11/05 01:36:25, Nico wrote:
> On 2015/11/05 01:31:45, pcc1 wrote:
> > I *think* this is ok. The only bots that actually change config are Windows
> bots
> > (which don't care about the value of clang_use_chrome_plugins)
> 
> They do care about this, it controls if the plugin is enabled (even though
it's
> always compiled in).

Oh, so they do. (I saw 'OS!="win"' and stopped reading.) I also didn't realise
that the ToT builders build the plugins, which was a little surprising. I've
adjusted the code to keep the existing config on Windows with a TODO to make
things consistent.

[Nico, 2015-11-05 02:08:26]

lgtm, thanks, this is a nice cleanup.

[pcc1, 2015-11-05 02:09:20]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2015-11-05 02:09:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420993007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420993007/20001

[commit-bot: I haz the power, 2015-11-05 02:17:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 02:17:16]

Try jobs failed on following builders:
  build_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit...)

[pcc1, 2015-11-05 02:20:46]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2015-11-05 02:20:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420993007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420993007/20001

[commit-bot: I haz the power, 2015-11-05 02:26:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 02:26:56]

Try jobs failed on following builders:
  build_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit...)

[pcc1, 2015-11-05 02:38:30]

Description was changed from

==========
Simplify config for Clang ToT builders.

BUG=
R=thakis@chromium.org
==========

to

==========
Simplify config for Clang ToT builders.

BUG=
R=thakis@chromium.org
==========

[pcc1, 2015-11-05 02:38:30]

pcc@chromium.org changed reviewers:
+ sergeyberezin@chromium.org

[pcc1, 2015-11-05 02:38:54]

On 2015/11/05 02:26:56, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   build_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/build_presubmit...)

sergyberezin: PTAL

[Sergey Berezin, 2015-11-06 00:10:02]

lgtm

[pcc1, 2015-11-06 02:34:28]

The CQ bit was checked by pcc@chromium.org

[commit-bot: I haz the power, 2015-11-06 02:34:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420993007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420993007/20001

[commit-bot: I haz the power, 2015-11-06 02:37:01]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297474