Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Issue 1420993007: Simplify config for Clang ToT builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: remove Windows config delta Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py b/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
index 3c021408af3a89986281dd552f132fe25b6f4c15..2f8fbc302faea7c6d1d0de8af3fffaa3a31731e3 100644
--- a/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
+++ b/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
@@ -1094,10 +1094,6 @@ SPEC = {
# Enable debug info, as on official builders, to catch issues with
# optimized debug info.
'linux_dump_symbols': '1',
-
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'testing': {
@@ -1140,10 +1136,6 @@ SPEC = {
},
'GYP_DEFINES': {
'werror': '',
-
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'testing': { 'platform': 'linux', },
@@ -1166,9 +1158,6 @@ SPEC = {
'chromium_apply_config': ['lsan'],
'GYP_DEFINES': {
'werror': '',
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'testing': { 'platform': 'linux', },
@@ -1208,9 +1197,6 @@ SPEC = {
},
'GYP_DEFINES': {
'werror': '',
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'testing': { 'platform': 'linux', },
@@ -1253,9 +1239,6 @@ SPEC = {
'GYP_DEFINES': {
'component': 'shared_library',
'werror': '',
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'android_config': 'clang_asan_tot_release_builder',
@@ -1300,9 +1283,6 @@ SPEC = {
'GYP_DEFINES': {
'component': 'shared_library',
'werror': '',
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'testing': { 'platform': 'mac', },
@@ -1343,9 +1323,6 @@ SPEC = {
},
'GYP_DEFINES': {
'werror': '',
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'testing': { 'platform': 'mac', },
@@ -1367,9 +1344,6 @@ SPEC = {
},
'GYP_DEFINES': {
'werror': '',
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'bot_type': 'builder',
'testing': { 'platform': 'mac', },
@@ -1412,9 +1386,6 @@ SPEC = {
},
'GYP_DEFINES': {
'werror': '',
- # Plugin flags often need to be changed when using a plugin newer than
- # the latest Clang package, so disable plugins.
- 'clang_use_chrome_plugins': '0',
},
'testing': {
'platform': 'mac',

Powered by Google App Engine
This is Rietveld 408576698