Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 14209006: A little code refactoring on FastCloneShallowArrayStub (Closed)

Created:
7 years, 8 months ago by haitao.feng
Modified:
7 years, 8 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

A little code refactoring on FastCloneShallowArrayStub

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
haitao.feng
Use DoGenerateCode like the other stubs.
7 years, 8 months ago (2013-04-15 04:37:19 UTC) #1
danno
This change was already landed through another patch
7 years, 8 months ago (2013-04-17 13:52:45 UTC) #2
haitao.feng
It seems that this instance (FastCloneShallowArrayStub) is missed by that patch.
7 years, 8 months ago (2013-04-18 08:28:06 UTC) #3
danno
lgtm
7 years, 8 months ago (2013-04-18 15:30:28 UTC) #4
danno
I just tried to apply this to bleeding edge, and it doesn't apply. Also, I ...
7 years, 8 months ago (2013-04-18 15:32:52 UTC) #5
haitao.feng
7 years, 8 months ago (2013-04-19 07:03:19 UTC) #6
It is already in with your CL https://codereview.chromium.org/13886013 :)

Powered by Google App Engine
This is Rietveld 408576698