Issue 13886013: Add infrastructure to automatucally generate IC miss stubs

Issue 13886013: Add infrastructure to automatucally generate IC miss stubs (Closed)

Created:
7 years, 8 months ago by danno

Modified:
7 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add infrastructure to automatucally generate IC miss stubs Committed: http://code.google.com/p/v8/source/detail?r=14342

Patch Set 2 : Address review feedback #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+248 lines, -49 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	src/code-stubs.h	View	1	18 chunks	+76 lines, -37 lines	0 comments	Download
M	src/code-stubs.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1	4 chunks	+80 lines, -12 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	src/ic.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. https://codereview.chromium.org/13886013/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/13886013/diff/1/src/code-stubs-hydrogen.cc#newcode249 src/code-stubs-hydrogen.cc:249: // The miss case without stack parameters can ...

7 years, 8 months ago (2013-04-18 17:43:07 UTC) #2

danno

Committed patchset #2 manually as r14342 (presubmit successful).

7 years, 8 months ago (2013-04-18 20:37:39 UTC) #3

danno

7 years, 8 months ago (2013-04-19 06:47:41 UTC) #4

Message was sent while issue was closed.

Feedback addressed and landed.

https://codereview.chromium.org/13886013/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/13886013/diff/1/src/code-stubs-hydrogen.cc#ne...
src/code-stubs-hydrogen.cc:249: // The miss case without stack parameters can
use a light-weight tail-call.
On 2013/04/18 17:43:07, Jakob wrote:
> I don't see any tail calls around here.

Done.

https://codereview.chromium.org/13886013/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/13886013/diff/1/src/code-stubs.h#newcode297
src/code-stubs.h:297: Isolate* isolate) {
On 2013/04/18 17:43:07, Jakob wrote:
> unnecessary change?

Done.

Expand Messages | Collapse Messages