Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1420883006: Move blimp_layer_tree_settings.h/cc to client. (Closed)

Created:
5 years, 1 month ago by David Trainor- moved to gerrit
Modified:
5 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, dtrainor+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move blimp_layer_tree_settings.h/cc to client. These aren't needed by the engine, so I'm moving this to blimp/client from blimp/common to fix an engine build error. BUG=527655 Committed: https://crrev.com/2f3eb21a4d3a900cfaeb3663ed0a173e132fc5f3 Cr-Commit-Position: refs/heads/master@{#358721}

Patch Set 1 #

Patch Set 2 : Tweaked a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -320 lines) Patch
M blimp/client/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M blimp/client/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
A blimp/client/compositor/blimp_layer_tree_settings.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A + blimp/client/compositor/blimp_layer_tree_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/common/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M blimp/common/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/common/compositor/blimp_layer_tree_settings.h View 1 chunk +0 lines, -33 lines 0 comments Download
D blimp/common/compositor/blimp_layer_tree_settings.cc View 1 chunk +0 lines, -270 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
David Trainor- moved to gerrit
5 years, 1 month ago (2015-11-09 23:33:44 UTC) #2
Wez
lgtm
5 years, 1 month ago (2015-11-09 23:37:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420883006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420883006/20001
5 years, 1 month ago (2015-11-09 23:39:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 00:54:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 00:55:27 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f3eb21a4d3a900cfaeb3663ed0a173e132fc5f3
Cr-Commit-Position: refs/heads/master@{#358721}

Powered by Google App Engine
This is Rietveld 408576698