Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1420843005: Revert of "webgl: optimize webgl.texSubImage2D(video) path." (Closed)

Created:
5 years, 1 month ago by Zhenyao Mo
Modified:
5 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, eric.carlson_apple.com, mlamouri+watch-media_chromium.org, rwlbuis, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-html_chromium.org, jam, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, mlamouri+watch-content_chromium.org, vmpstr+blinkwatch_chromium.org, philipj_slow, jbroman, feature-media-reviews_chromium.org, krit, piman+watch_chromium.org, mlamouri+watch-blink_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, f(malita), mkwst+moarreviews-renderer_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "webgl: optimize webgl.texSubImage2D(video) path." (patchset #3 id:40001 of https://codereview.chromium.org/1413833006/ ) Reason for revert: Reverting this due to the security concerns piman raised, also it broke video related texture tests on Android. Original issue's description: > Reland of "webgl: optimize webgl.texSubImage2D(video) path." > > Original CL: https://codereview.chromium.org/1315323006/ > Revert: https://codereview.chromium.org/1418513016 > > Reason for revert: > Reverting to address webgl_conformance_tests break in: > https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/3534 > > Reason for reland: > There is a bug in glCopySubTextureCHROMIUM extension. GLES2DecoderImpl::DoCopySubTextureCHROMIUM/DoCompressedCopySubTextureCHROMIUM > uses ValidForTexture to check dimensions of source texture. If the source > texture is backed by GL Image, the decoder can report false positive error. > This CL doesn't use Texture::ValidForTexture() for GL Image. > > TEST=WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video_* > BUG=349871, 504773, 549531 > > Committed: https://crrev.com/7c26f04cf12c2c72fdab8e4764faf9305724c7ee > Cr-Commit-Position: refs/heads/master@{#357100} TBR=kbr@chromium.org,dalecurtis@chromium.org,philipj@opera.com,zmo@google.com,piman@chromium.org,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=349871, 504773, 549531 Committed: https://crrev.com/57d577a356a1ccc722dd5ef08e5481ee7a033c87 Cr-Commit-Position: refs/heads/master@{#357134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -277 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 3 chunks +11 lines, -22 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +12 lines, -16 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +5 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 1 chunk +5 lines, -24 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 4 chunks +10 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 4 chunks +25 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 2 chunks +4 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp View 1 chunk +2 lines, -17 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +10 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Created Revert of "webgl: optimize webgl.texSubImage2D(video) path."
5 years, 1 month ago (2015-10-30 18:22:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420843005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420843005/1
5 years, 1 month ago (2015-10-30 18:23:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 18:29:07 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 18:31:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57d577a356a1ccc722dd5ef08e5481ee7a033c87
Cr-Commit-Position: refs/heads/master@{#357134}

Powered by Google App Engine
This is Rietveld 408576698