Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1418513016: Revert of webgl: optimize webgl.texSubImage2D(video) path. (Closed)

Created:
5 years, 1 month ago by dcaiafa
Modified:
5 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org, oetuaho-nv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of webgl: optimize webgl.texSubImage2D(video) path. (patchset #10 id:240001 of https://codereview.chromium.org/1315323006/ ) Reason for revert: Reverting to address webgl_conformance_tests break in: https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%209%29/builds/3534 Original issue's description: > webgl: optimize webgl.texSubImage2D(video) path. > > Currently, texSubImage2D(video) requires glReadPixels to copy video texture to > target texture. This CL makes infra structure to copy video texture to target > texture directly. Blink will turn on the direct path. > > In addition, it will reduce WebGL video test flakiness significantly. > > TEST=video texture test on webgl_conformance > ./content/test/gpu/run_gpu_test.py webgl_conformance --browser=release --story-filter=WebglConformance.conformance_textures_video_tex_image_and_sub_image_2d_with_video > BUG=349871, 504773 > > Committed: https://crrev.com/01542ac6d0fbec6aa78e33e6c7ec49a582072ea9 > Cr-Commit-Position: refs/heads/master@{#356390} TBR=piman@chromium.org,dalecurtis@chromium.org,kbr@chromium.org,oetuaho@nvidia.com,dpranke@chromium.org,philipj@opera.com,dongseong.hwang@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=349871, 504773 Committed: https://crrev.com/bfa196022345aa9bd694d200f107b6d809178715 Cr-Commit-Position: refs/heads/master@{#356415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -261 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 3 chunks +11 lines, -22 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +5 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 1 chunk +5 lines, -24 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 4 chunks +10 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 4 chunks +25 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 2 chunks +4 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp View 1 chunk +2 lines, -17 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaPlayer.h View 1 chunk +10 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcaiafa
Created Revert of webgl: optimize webgl.texSubImage2D(video) path.
5 years, 1 month ago (2015-10-27 22:27:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418513016/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418513016/1
5 years, 1 month ago (2015-10-27 22:28:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 22:30:06 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 22:30:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfa196022345aa9bd694d200f107b6d809178715
Cr-Commit-Position: refs/heads/master@{#356415}

Powered by Google App Engine
This is Rietveld 408576698