third_party/WebKit/Source/core/dom/Element.h - Issue 1420653003: Fix an optimisation in ContainerNode::notifyNodeInsertedInternal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.h

Issue 1420653003: Fix an optimisation in ContainerNode::notifyNodeInsertedInternal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix assertion Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Element.h

diff --git a/third_party/WebKit/Source/core/dom/Element.h b/third_party/WebKit/Source/core/dom/Element.h

index 213c3ae385d8661c44184f48775d02cdb8a4503a..f048911844e1bf668fb29bad33b6821078b640b7 100644

--- a/third_party/WebKit/Source/core/dom/Element.h

+++ b/third_party/WebKit/Source/core/dom/Element.h

@@ -804,7 +804,7 @@ inline Node::InsertionNotificationRequest Node::insertedInto(ContainerNode* inse

{

ASSERT(!childNeedsStyleInvalidation());

ASSERT(!needsStyleInvalidation());

- ASSERT(insertionPoint->inDocument() || isContainerNode());

+ ASSERT(insertionPoint->inDocument() || insertionPoint->isInShadowTree() || isContainerNode());

if (insertionPoint->inDocument()) {

setFlag(InDocumentFlag);

insertionPoint->document().incrementNodeCount();

« no previous file with comments | « third_party/WebKit/Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »