third_party/WebKit/Source/core/dom/ContainerNode.cpp - Issue 1420653003: Fix an optimisation in ContainerNode::notifyNodeInsertedInternal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 1420653003: Fix an optimisation in ContainerNode::notifyNodeInsertedInternal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix assertion Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-no-shadow-event-expected.txt ('k') | third_party/WebKit/Source/core/dom/Element.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ContainerNode.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.cpp b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

index d5c733026cb9635ebaf60dca524c3734bd0a58f0..dbf7e0e11b0177c07c3ee030329e388699e1f141 100644

--- a/third_party/WebKit/Source/core/dom/ContainerNode.cpp

+++ b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

@@ -836,8 +836,8 @@ void ContainerNode::notifyNodeInsertedInternal(Node& root, NodeVector& postInser

for (Node& node : NodeTraversal::inclusiveDescendantsOf(root)) {

// As an optimization we don't notify leaf nodes when when inserting

- // into detached subtrees.

- if (!inDocument() && !node.isContainerNode())

+ // into detached subtrees that are not in a shadow tree.

+ if (!inDocument() && !isInShadowTree() && !node.isContainerNode())

continue;

if (Node::InsertionShouldCallDidNotifySubtreeInsertions == node.insertedInto(this))

postInsertionNotificationTargets.append(&node);