Cleanup GpuMemoryManager and helpers.

Cleanup GpuMemoryManager and helpers.

Now that gpu mem calculation has been moved to compositor, remove unused code.
This removes GpuMemoryManagerClient and related unit tests.

BUG=537563
Committed: https://crrev.com/d1650935866e4efc94cbb5d4ce89f0af97cc4da9
Cr-Commit-Position: refs/heads/master@{#359984}

[sohanjg, 2015-11-10 12:07:30]

sohan.jyoti@samsung.com changed reviewers:
+ ccameron@chromium.org, danakj@chromium.org, piman@chromium.org

[sohanjg, 2015-11-10 12:07:30]

This is pretty rough, can you please check if i am missing something. thanks.

[piman, 2015-11-10 23:34:49]

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
File content/common/gpu/gpu_command_buffer_stub.h (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
content/common/gpu/gpu_command_buffer_stub.h:101: gfx::Size GetSurfaceSize()
const;
This doesn't look like it's called any more. Remove?

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
content/common/gpu/gpu_command_buffer_stub.h:103: void
SuggestHaveFrontBuffer(bool suggest_have_frontbuffer);
Same here.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
content/common/gpu/gpu_command_buffer_stub.h:104: bool GetTotalGpuMemory(uint64*
bytes);
Same here, and can remove total_gpu_memory_.

I think in turn that means GLContext::GetTotalGpuMemory is not needed anymore
and could be removed (including concrete implementations).

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager.cc (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:38: client_hard_limit_bytes_(0),
This is never changed. Remove?

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager.h (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.h:29: GpuMemoryManager(GpuChannelManager*
channel_manager);
nit: explicit

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_uma_stats.h (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_uma_stats.h:29: size_t bytes_limit;
This could be removed, it's always 0 (see gpu_memory_manager.cc comments)

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_uma_stats.h:35: uint32 window_count;
This could be removed too. It's not set anywhere (and actually uninitialized)

[sohanjg, 2015-11-13 07:30:44]

Sorry for the delay, was OOO.
Can you please take a look, thanks.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
File content/common/gpu/gpu_command_buffer_stub.h (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
content/common/gpu/gpu_command_buffer_stub.h:101: gfx::Size GetSurfaceSize()
const;
On 2015/11/10 23:34:48, piman (slow to review) wrote:
> This doesn't look like it's called any more. Remove?

Done.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
content/common/gpu/gpu_command_buffer_stub.h:103: void
SuggestHaveFrontBuffer(bool suggest_have_frontbuffer);
On 2015/11/10 23:34:49, piman (slow to review) wrote:
> Same here.

Done.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_comm...
content/common/gpu/gpu_command_buffer_stub.h:104: bool GetTotalGpuMemory(uint64*
bytes);
On 2015/11/10 23:34:48, piman (slow to review) wrote:
> Same here, and can remove total_gpu_memory_.
> 
> I think in turn that means GLContext::GetTotalGpuMemory is not needed anymore
> and could be removed (including concrete implementations).

Done.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager.cc (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.cc:38: client_hard_limit_bytes_(0),
On 2015/11/10 23:34:49, piman (slow to review) wrote:
> This is never changed. Remove?

Done.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_manager.h (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_manager.h:29: GpuMemoryManager(GpuChannelManager*
channel_manager);
On 2015/11/10 23:34:49, piman (slow to review) wrote:
> nit: explicit

Done.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
File content/common/gpu/gpu_memory_uma_stats.h (right):

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_uma_stats.h:29: size_t bytes_limit;
On 2015/11/10 23:34:49, piman (slow to review) wrote:
> This could be removed, it's always 0 (see gpu_memory_manager.cc comments)

Done.

https://codereview.chromium.org/1420533009/diff/1/content/common/gpu/gpu_memo...
content/common/gpu/gpu_memory_uma_stats.h:35: uint32 window_count;
On 2015/11/10 23:34:49, piman (slow to review) wrote:
> This could be removed too. It's not set anywhere (and actually uninitialized)

Done.

[piman, 2015-11-14 01:20:08]

lgtm

[sohanjg, 2015-11-14 05:08:59]

The CQ bit was checked by sohan.jyoti@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-14 05:09:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420533009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420533009/20001

[commit-bot: I haz the power, 2015-11-14 07:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-14 07:34:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sohanjg, 2015-11-14 10:04:48]

Description was changed from

==========
Cleanup GpuMemoryManager and helpers.

Now that gpu mem calculation has been moved to compositor, remove unused code.

BUG=537563
==========

to

==========
Cleanup GpuMemoryManager and helpers.

Now that gpu mem calculation has been moved to compositor, remove unused code.

BUG=537563
==========

[sohanjg, 2015-11-16 06:36:22]

Description was changed from

==========
Cleanup GpuMemoryManager and helpers.

Now that gpu mem calculation has been moved to compositor, remove unused code.

BUG=537563
==========

to

==========
Cleanup GpuMemoryManager and helpers.

Now that gpu mem calculation has been moved to compositor, remove unused code.
This removes GpuMemoryManagerClient and related unit tests.

BUG=537563
==========

[sohanjg, 2015-11-16 06:42:17]

The CQ bit was checked by sohan.jyoti@samsung.com

[commit-bot: I haz the power, 2015-11-16 06:42:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420533009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420533009/20001

[commit-bot: I haz the power, 2015-11-16 06:50:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 06:50:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sohanjg, 2015-11-16 07:27:25]

On 2015/11/16 06:50:39, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

dcheng@, can you please have a look at gpu_mesaage.h cleanup. thanks.

[sohanjg, 2015-11-16 07:28:05]

sohan.jyoti@samsung.com changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-11-17 01:25:57]

rs lgtm for removals in gpu_messages.h

[sohanjg, 2015-11-17 02:14:56]

The CQ bit was checked by sohan.jyoti@samsung.com

[commit-bot: I haz the power, 2015-11-17 02:15:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420533009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420533009/20001

[commit-bot: I haz the power, 2015-11-17 02:47:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-17 02:48:47]

Patchset 2 (id:??) landed as
https://crrev.com/d1650935866e4efc94cbb5d4ce89f0af97cc4da9
Cr-Commit-Position: refs/heads/master@{#359984}