[Smart Lock, Prefs reconciliation] Finished componetization.

[Smart Lock, Prefs reconciliation] Finished componetization.

BUG=517087
Committed: https://crrev.com/c4ac48d076e71eb99e9f6ca365526ff8ea8fa8fb
Cr-Commit-Position: refs/heads/master@{#357657}

[melandory, 2015-10-30 12:28:38]

Patchset #1 (id:1) has been deleted

[melandory, 2015-10-30 14:10:51]

Patchset #1 (id:20001) has been deleted

[melandory, 2015-10-30 14:11:57]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2015-10-30 14:11:58]

Hi Vaclav,

PTAL. 

Thanks!

[blundell, 2015-10-30 14:15:31]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2015-10-30 14:15:31]

https://codereview.chromium.org/1420533007/diff/40001/components/password_man...
File components/password_manager/sync/browser/DEPS (right):

https://codereview.chromium.org/1420533007/diff/40001/components/password_man...
components/password_manager/sync/browser/DEPS:2:
"+components/keyed_service/content",
Drive-by: this dependency is in effect a //content dependency (transitively) and
is no good for code shared with iOS. It also isn't necessary AFAICT: I think the
includes are stale.

[melandory, 2015-10-30 16:47:47]

Description was changed from

==========
[Smart Lock, Prefs reconciliation] Finished componetozation.

BUG=517087
==========

to

==========
[Smart Lock, Prefs reconciliation] Finished componetization.

BUG=517087
==========

[vabr (Chromium), 2015-10-30 17:52:44]

LGTM, thank you!
Vaclav

[melandory, 2015-11-02 09:25:51]

melandory@chromium.org changed reviewers:
+ pvalenzuela@chromium.org, skuhne@chromium.org

[melandory, 2015-11-02 09:25:51]

skuhne@chromium.org: Please review changes in 

chrome/browser/profiles/profile_manager.cc

pvalenzuela@chromium.org: Please review changes in

chrome/browser/sync/test/integration/password_manager_setting_migrator_helper.cc

https://codereview.chromium.org/1420533007/diff/40001/components/password_man...
File components/password_manager/sync/browser/DEPS (right):

https://codereview.chromium.org/1420533007/diff/40001/components/password_man...
components/password_manager/sync/browser/DEPS:2:
"+components/keyed_service/content",
On 2015/10/30 14:15:31, blundell wrote:
> Drive-by: this dependency is in effect a //content dependency (transitively)
and
> is no good for code shared with iOS. It also isn't necessary AFAICT: I think
the
> includes are stale.

Done. Thanks for pointing this out.

[melandory, 2015-11-02 09:25:53]

skuhne@chromium.org: Please review changes in 

chrome/browser/profiles/profile_manager.cc

pvalenzuela@chromium.org: Please review changes in

chrome/browser/sync/test/integration/password_manager_setting_migrator_helper.cc

[melandory, 2015-11-02 09:25:58]

skuhne@chromium.org: Please review changes in 

chrome/browser/profiles/profile_manager.cc

pvalenzuela@chromium.org: Please review changes in

chrome/browser/sync/test/integration/password_manager_setting_migrator_helper.cc

[Mr4D (OOO till 08-26), 2015-11-02 15:30:43]

ProfileManager lgtm

[pval...(no longer on Chromium), 2015-11-02 19:07:42]

chrome/browser/sync/test lgtm

[melandory, 2015-11-02 19:09:13]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-11-02 19:09:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420533007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420533007/60001

[commit-bot: I haz the power, 2015-11-02 19:38:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 19:38:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[melandory, 2015-11-02 20:29:49]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-02 20:30:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420533007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420533007/60001

[commit-bot: I haz the power, 2015-11-02 20:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-02 20:44:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[melandory, 2015-11-03 09:24:23]

melandory@chromium.org changed reviewers:
+ battre@chromium.org, erg@chromium.org

[melandory, 2015-11-03 09:24:24]

erg@, battre@:

Please review changes in DEPS.

Thanks!

[battre, 2015-11-03 10:24:45]

components/password_manager/sync/browser/DEPS LGTM

[Elliot Glaysher, 2015-11-03 18:26:19]

trivial header name change in profiles lgtm

[melandory, 2015-11-03 21:09:46]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-11-03 21:11:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1420533007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1420533007/60001

[commit-bot: I haz the power, 2015-11-03 22:40:12]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-11-03 22:41:20]

Patchset 2 (id:??) landed as
https://crrev.com/c4ac48d076e71eb99e9f6ca365526ff8ea8fa8fb
Cr-Commit-Position: refs/heads/master@{#357657}

[sdefresne, 2016-04-19 13:32:49]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-04-19 13:32:50]

https://codereview.chromium.org/1420533007/diff/60001/components/password_man...
File components/password_manager/sync/browser/BUILD.gn (right):

https://codereview.chromium.org/1420533007/diff/60001/components/password_man...
components/password_manager/sync/browser/BUILD.gn:34:
"password_manager_setting_migrator_service_unittest.cc",
Hi, you forgot to add this test to components/components_tests.gyp.

[vabr (Chromium), 2016-04-19 13:38:32]

On 2016/04/19 13:32:50, sdefresne wrote:
>
https://codereview.chromium.org/1420533007/diff/60001/components/password_man...
> File components/password_manager/sync/browser/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1420533007/diff/60001/components/password_man...
> components/password_manager/sync/browser/BUILD.gn:34:
> "password_manager_setting_migrator_service_unittest.cc",
> Hi, you forgot to add this test to components/components_tests.gyp.

Oops, that was living in the GN-only future. :)
Will put up a CL to fix that.
Thanks for spotting this!
Vaclav

[vabr (Chromium), 2016-04-19 13:44:21]

> Will put up a CL to fix that.
https://codereview.chromium.org/1902773002, waiting for trybots go green, will
send for review afterwards.

[sdefresne, 2016-04-19 13:51:49]

On 2016/04/19 at 13:44:21, vabr wrote:
> > Will put up a CL to fix that.
> https://codereview.chromium.org/1902773002, waiting for trybots go green, will
send for review afterwards.

Found this while I was converting components_unittests to gn with iOS.
The tests fails on iOS, created bug
https://bugs.chromium.org/p/chromium/issues/detail?id=604721.