Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1902773002: Add password_manager_setting_migrator_service_unittest.cc to GYP (Closed)

Created:
4 years, 8 months ago by vabr (Chromium)
Modified:
4 years, 8 months ago
Reviewers:
melandory, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add password_manager_setting_migrator_service_unittest.cc to GYP It was only added to GN build files in https://codereview.chromium.org/1420533007/. R=sdefresne@chromium.org, melandory@chromium.org BUG=517087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902773002/1
4 years, 8 months ago (2016-04-19 13:42:53 UTC) #2
sdefresne
On 2016/04/19 at 13:42:53, commit-bot wrote: > Dry run: CQ is trying da patch. Follow ...
4 years, 8 months ago (2016-04-19 13:52:30 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/161811)
4 years, 8 months ago (2016-04-19 13:58:16 UTC) #5
melandory
On 2016/04/19 13:58:16, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 8 months ago (2016-04-19 14:09:57 UTC) #6
vabr (Chromium)
4 years, 8 months ago (2016-04-19 15:41:26 UTC) #7
On 2016/04/19 14:09:57, melandory wrote:
> On 2016/04/19 13:58:16, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
> 
> lgtm
> 
> Working on fixing tests.

Will close this CL, because melandory@ is fixing the test, and can enable it
together with the fix.

Powered by Google App Engine
This is Rietveld 408576698