components/password_manager/sync/browser/DEPS - Issue 1420533007: [Smart Lock, Prefs reconciliation] Finished componetization.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/password_manager/sync/browser/DEPS

Issue 1420533007: [Smart Lock, Prefs reconciliation] Finished componetization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/password_manager/sync/browser/BUILD.gn ('k') | components/password_manager/sync/browser/password_manager_setting_migrator_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+components/keyed_service/content",
	blundell 2015/10/30 14:15:31 Drive-by: this dependency is in effect a //content Drive-by: this dependency is in effect a //content dependency (transitively) and is no good for code shared with iOS. It also isn't necessary AFAICT: I think the includes are stale. melandory 2015/11/02 09:25:51 Done. Thanks for pointing this out. Show quoted text On 2015/10/30 14:15:31, blundell wrote: > Drive-by: this dependency is in effect a //content dependency (transitively) and > is no good for code shared with iOS. It also isn't necessary AFAICT: I think the > includes are stale. Done. Thanks for pointing this out.
	3 "+components/keyed_service/core",

2 "+components/pref_registry",	4 "+components/pref_registry",

3 "+components/signin/core/browser",	5 "+components/signin/core/browser",

4 "+components/signin/core/common",	6 "+components/signin/core/common",

5 "+components/sync_driver",	7 "+components/sync_driver",

	8 "+components/syncable_prefs",

6 "+google_apis/gaia",	9 "+google_apis/gaia",

7 "+sync/internal_api/public",	10 "+sync/internal_api/public",

8 ]	11 ]

OLD	NEW